Extract type-tests from @glint/template that cause dependency problems to their own package#855
Merged
NullVoxPopuli merged 3 commits intomainfrom Mar 27, 2025
Merged
Conversation
NullVoxPopuli
added
the
internal
NullVoxPopuli
force-pushed
the
nvp/move-template-tests
branch
from
eba39f5 to
d532d78
Compare
machty
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar deal as: #843
Required for: #817
CI will think this is a bit of a no-op for now, but, locally:
pnpm test:typecheckin both of the @glint/template and package-test-template packages should pass