Prefer variables in scope over global variables#865
Merged
NullVoxPopuli merged 1 commit intotyped-ember:mainfrom Mar 31, 2025
Merged
Prefer variables in scope over global variables#865NullVoxPopuli merged 1 commit intotyped-ember:mainfrom
NullVoxPopuli merged 1 commit intotyped-ember:mainfrom
Conversation
mogstad
force-pushed
the
push-uovqtzurwlpu
branch
2 times, most recently
from
101f058 to
2c36249
Compare
Contributor
|
I think we should treat it like a bug in ember. We don't want weird things to be encoded in Glint, as this makes Glint less flexible. but also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #864
Seems like there is an edge case with
actionhelper, unsure if we should treat it as a bug in Ember or add an edge case for it in thetreatGlobalcheck.Ref: #864 (comment)