Drop support for @types/ember* only use native/built-in types#820
Merged
Drop support for @types/ember* only use native/built-in types#820
Conversation
NullVoxPopuli
force-pushed
the
nvp/ditch-DT-in-favor-of-native-types
branch
from
8947735 to
0147a01
Compare
Contributor
Author
|
The one failing test exists on main |
machty
reviewed
Mar 20, 2025
Contributor
machty
left a comment
machty
left a comment
There was a problem hiding this comment.
Looks good just think one comment could clarify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks: #818
This doesn't mean DT types won't work.
It means that Glint now doesn't formally support DT types, but if you have "something" that happens to define correct ember-types, then we're in a good spot -- doesn't matter what that "something" is -- could be the ember native types, or the types from DT -- we mainly want the glint repo to be easier to work with.
irrelevant / former issues
Potentially Blocked on: microsoft/vscode#130367