Split typechecking from tests#731
Merged
NullVoxPopuli merged 10 commits intomainfrom Jun 21, 2024
Merged
Conversation
b7e23b2 to
27fa8b7
Compare
27fa8b7 to
4b7a141
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to more fine-grainedly seeing what's going on in CI, without just blanked "red" vs "green" status.
This does cost more install time -- but if we eventually move to pnpm, we'll re-gain that time back.
tl;dr:
probably best to review per-commit
Ran in to the need for yarnpkg/yarn#6739
but ugh.