Skip to content

Split typechecking from tests#731

Merged
NullVoxPopuli merged 10 commits intomainfrom
split-typechecking-from-tests
Jun 21, 2024
Merged

Split typechecking from tests#731
NullVoxPopuli merged 10 commits intomainfrom
split-typechecking-from-tests

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 21, 2024

This allows us to more fine-grainedly seeing what's going on in CI, without just blanked "red" vs "green" status.

This does cost more install time -- but if we eventually move to pnpm, we'll re-gain that time back.

tl;dr:

  • pull out linting to its own job
  • pull out type checking to its own job
  • fix linting for the unstable-release package
  • resolve lint errors in the rest of the repo
  • upgrade to prettier 3
  • lint:fix (most of the changes)

probably best to review per-commit

Ran in to the need for yarnpkg/yarn#6739
but ugh.

@NullVoxPopuli NullVoxPopuli added the internal Changes that don't impact the published packages label Jun 21, 2024
@NullVoxPopuli NullVoxPopuli force-pushed the split-typechecking-from-tests branch 2 times, most recently from b7e23b2 to 27fa8b7 Compare June 21, 2024 19:07
@NullVoxPopuli NullVoxPopuli force-pushed the split-typechecking-from-tests branch from 27fa8b7 to 4b7a141 Compare June 21, 2024 19:28
@NullVoxPopuli NullVoxPopuli merged commit fcc2294 into main Jun 21, 2024
@NullVoxPopuli NullVoxPopuli deleted the split-typechecking-from-tests branch June 21, 2024 19:54
@github-actions github-actions Bot mentioned this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes that don't impact the published packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant