Skip to content

docs: use gjs as codefence lang#725

Merged
NullVoxPopuli merged 2 commits intotyped-ember:mainfrom
IgnaceMaes:gjs-codefences
Jun 20, 2024
Merged

docs: use gjs as codefence lang#725
NullVoxPopuli merged 2 commits intotyped-ember:mainfrom
IgnaceMaes:gjs-codefences

Conversation

@IgnaceMaes
Copy link
Copy Markdown
Contributor

Glimmer JS/TS syntax highlighting support was added to GitHub a couple of months ago. This PR uses that lang for codefences where <template> tag is being used.

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

gjs works:

const two = 2;

<template>
  {{two}}
</template>

gts:

const two = 2;

<template>
  {{two}}
</template>

glimmer-ts:

const two = 2;

<template>
  {{two}}
</template>

did we misconfigure something in linguist?

@IgnaceMaes
Copy link
Copy Markdown
Contributor Author

It's because gts already existed prior to us adding GJS/GTS support.

In search you can see it detects it as Gerber image:

Screenshot 2024-06-17 at 14 09 40

https://github.com/search?q=%28path%3A*.gts%29+AND+%28content%3A%3Ctemplate%3E+OR+content%3A%40glimmer+OR+content%3A%40ember%29+NOT+is%3Afork&type=code

Not sure if this can be changed, or if GitHub works with first come, first served.

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

hmm. that's silly

@NullVoxPopuli NullVoxPopuli merged commit a4162f0 into typed-ember:main Jun 20, 2024
@NullVoxPopuli NullVoxPopuli added the documentation Improvements or additions to documentation label Jun 20, 2024
@github-actions github-actions Bot mentioned this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants