Skip to content

Typed ember/resolve config from extends package#782

Merged
NullVoxPopuli merged 4 commits intotyped-ember:mainfrom
iarroyo:typed-ember/resolve-config-from-extends-package
Jan 3, 2025
Merged

Typed ember/resolve config from extends package#782
NullVoxPopuli merged 4 commits intotyped-ember:mainfrom
iarroyo:typed-ember/resolve-config-from-extends-package

Conversation

@iarroyo
Copy link
Copy Markdown

@iarroyo iarroyo commented Dec 28, 2024

Resolve glint configuration when your tsconfig.json extends from a package, ex

path: tsconfig.json

{
  "extends": "@package1"
}

path: node_modules/@package1/tsconfig.json

{
  "glint": {
    "environment": ["ember-loose", "ember-template-imports"]
  }
}

@iarroyo
Copy link
Copy Markdown
Author

iarroyo commented Dec 28, 2024

Please take a look when you have a chance, thank you
cc @NullVoxPopuli

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some lint/prettier issue, can you push up a fix? Code looks fine otherwise!

@iarroyo
Copy link
Copy Markdown
Author

iarroyo commented Jan 3, 2025

Looks like some lint/prettier issue, can you push up a fix? Code looks fine otherwise!

@NullVoxPopuli it should fix the prettier issue

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jan 3, 2025
@NullVoxPopuli NullVoxPopuli merged commit d8f63e9 into typed-ember:main Jan 3, 2025
@github-actions github-actions Bot mentioned this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants