Support extending multiple config files#838
Merged
NullVoxPopuli merged 1 commit intotyped-ember:mainfrom Mar 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
What happens in these new tests without the fix implemented?
I don't really understand why the expects are what they are. I would have expected an assertion of a value being present in the resolved config that is defined in the extended configs?
Why assert with normalize path?
Thank you!
Contributor
Author
There was a problem hiding this comment.
Without the fix they would throw an exception.
I agree the expects are a bit weird, I just continued using the existing pattern. Let me see if I can improve it.
Contributor
Author
There was a problem hiding this comment.
Invoked the loadConfigInput directly, but kept the existing setup there as well, to ensure the root dir is correctly.
Since TS5, tsconfig.json `extends` supports being an array of config files to extend.
mogstad
force-pushed
the
push-qzvstsxuklyz
branch
from
e7991d2 to
56b249a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since TS5, tsconfig.json
extendssupports being an array of config files to extend.Resolved #672