Skip to content

Fix glint cli build tests, parity with vue-tsc#740

Merged
machty merged 1 commit intomainfrom
glint-tsc-fixes
Jul 1, 2024
Merged

Fix glint cli build tests, parity with vue-tsc#740
machty merged 1 commit intomainfrom
glint-tsc-fixes

Conversation

@machty
Copy link
Copy Markdown
Contributor

@machty machty commented Jul 1, 2024

Per discussions in Discord, I'm pushing Glint v2's cli tools to behave as closely as possible to vue-tsc, which itself behaves much more closely to vanilla tsc. This means breaking changes for people using glint for type-checking as a CLI task, but here are a few reasons this is desirable / forgivable:

  1. The closer we are to Vue's tooling in general, the more we can tap into their larger community, e.g. there might be a confusion about glint that can be well explained by a closed issue in vue-tsc, rather than having this obscured by glint's behind-the-scenes flag-switching before shelling out to vanilla tsc.
  2. Perhaps glint v2 can remove the glint binary and introduce a new one called ember-tsc; this will be a much more loud and obvious breaking change such that anyone searching it can find the correct args to use rather than getting confused between existing and new documentation for glint v1 vs v2.

@machty machty force-pushed the glint-tsc-fixes branch from b01898c to 6cdb1f7 Compare July 1, 2024 18:49
@machty machty marked this pull request as ready for review July 1, 2024 18:49
@machty machty merged commit c9300e5 into main Jul 1, 2024
@machty machty deleted the glint-tsc-fixes branch July 1, 2024 18:49
@github-actions github-actions Bot mentioned this pull request Mar 23, 2025
@NullVoxPopuli NullVoxPopuli added the breaking A breaking change label Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking A breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants