Support (neo)vim filetypes for gts and gjs#856
Merged
NullVoxPopuli merged 4 commits intomainfrom Mar 27, 2025
Merged
Conversation
Contributor
|
@NullVoxPopuli lgtm, but just curious, does Vue's tooling avoid this because VSCode's languageID for .vue files' is the same as Neovim's? |
Contributor
Author
|
yea, vue chose just |
Contributor
Author
|
but they also have in-file differentiation of js/ts. so it makes sense that their outer file can be "just vue" our outer syntax is just js/ts, so we don't have as much control in that regard |
Contributor
|
LGTM but i think maybe just one of these tests would suffice because they all share the same branch point essentially. |
867719b to
1b1616f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glimmer-ts and glimmer-js is just what VSCode-flavored editors use.
neovim has a couple conventions for mixed syntax file-types:
${base_language}.${variant}, e.g.:${base_language}${variant}, (though, I don't like this one, and haven't implemented any equiv for glimmer -- I even removed these in favor of the above) e.g.:These in particular, may be intended for the (incorrect) flavors of
.jsand.tsfiles that have jsx inside them and don't declare so via their extension (this was common when jsx was new)Solves this problem when using ts-plugin mode in neovim: