Migrate tests to TS Plugin mode, remove option for old LS mode#811
Migrate tests to TS Plugin mode, remove option for old LS mode#811
Conversation
|
@machty FWIW: When upgrading from
– Are there perhaps another set of dependencies required after this PR? thanks! |
|
@johanrd what you're seeing makes sense because we need to publish a new version of the Glint VSCode extension. With the shift from LS to TS Plugin, we're no longer able to get away with using an older published VSCode extension version with edge glint. I believe by the end of the week (likely sooner) I should have an alpha version of VSCode extension published to start trying out TS Plugin, but FYI I expect many issues with this first alpha. If you want to use "edge-ish" glint in the meantime, I'd suggest pinning to the commit before the TS Plugin merge, which is 130d85f |
|
@johanrd we have a testable TS Plugin mode available from VSCode Marketplace; try the pre-release version 1.4.3+. See here for more details: https://github.com/typed-ember/glint/blob/main/GLINT_V2.md |

In a recent PR, Vue tooling has:
The timing is good for me to remove these features in Glint and to re-express old LS tests as TS Plugin instead. Otherwise we would experience continued awkward fracturing in Glint's codebase due to the way to way express certain TS tests in the old (and soon to be unused) LS mode, but then have/had no way to test TS Plugin-only stuff (e.g. hbs+ts loose mode two file components) other than to use slow VSCode acceptance tests.