Skip to content

use more specific nodes for open tag#839

Merged
NullVoxPopuli merged 1 commit intotyped-ember:mainfrom
patricklx:update-glimmer
Mar 25, 2025
Merged

use more specific nodes for open tag#839
NullVoxPopuli merged 1 commit intotyped-ember:mainfrom
patricklx:update-glimmer

Conversation

@patricklx
Copy link
Copy Markdown
Contributor

@patricklx patricklx commented Mar 25, 2025

there are now also following nodes:

  • name node: PathExpression
  • start tag node: Element openTag span

example:

/*
  <Foo.bar.x attr='2'></Foo.bar.x>
   ^-------- Element PathExpression node
  ^------------------ Element openTag span
                      ^----------- ElementEndNode
 */

afterwards completions/validations can be add for attributes and element tags
In #663

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Mar 25, 2025
@NullVoxPopuli NullVoxPopuli merged commit 9308e15 into typed-ember:main Mar 25, 2025
4 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants