Improve multi-byte character handling#842
Merged
NullVoxPopuli merged 6 commits intomainfrom Mar 26, 2025
Merged
Conversation
… be their own package -- to solve a dep cycle
Contributor
|
In parallel I started looking at this, and I think I found the issue of the multi-byte issue: https://github.com/typed-ember/glint/compare/main...mogstad:push-zuqwnylqqlpt?expand=0 |
Contributor
Author
|
excellent! let's see a PR! <3 |
Previously it was genrating the offset from the original source, but as the transformed code is different, the offseted character wasn't offset at the right spot
Template tags are converted into template literals, we need to ensure static content doesn't behave like a template literal, this means escaping backticks and dollar signs.
Escape and transform template string
Contributor
|
@NullVoxPopuli did this PR fix the issues referenced? |
This was referenced Mar 31, 2025
Contributor
Author
|
It fixed one of them -- the |
NullVoxPopuli
added a commit
that referenced
this pull request
Aug 25, 2025
Improve multi-byte character handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the issue: embroider-build/content-tag#45
If folks need to do anything with content-tag in the future, there is this: https://github.com/NullVoxPopuli/content-tag-utils
Hoping to resolve:
$character in template causes "No interpolated values in template strings" #840 (not a multi-byte issue, but "feels" similar)