feat: apply the rest of Optimism v1.0.3 to Kroma#49
Merged
chokobole merged 14 commits intofeat/apply-optimism-v1.0.3from May 15, 2023
Merged
feat: apply the rest of Optimism v1.0.3 to Kroma#49chokobole merged 14 commits intofeat/apply-optimism-v1.0.3from
chokobole merged 14 commits intofeat/apply-optimism-v1.0.3from
Conversation
|
Please update bindings! > cd bindings
> make more
> git diff
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: bindings/kromaportal_more.go
modified: bindings/l1block_more.go
modified: bindings/systemconfig_more.go |
chokobole
reviewed
May 11, 2023
When I did like below, it gives outputs like above. # at packages/contracts
> npx hardhat compile
# at bindings
> make moreStrangely, if I tried after removing |
Contributor
Author
I think you should delete your ./packages/contracts/cache folder, that is created before by # at ./packages/contracts
> yarn clean && npx hardhat compile
# at ./bindings
> make moreor just simply # at ./
> make bindings |
6e9e3a7 to
3ea0b8d
Compare
Contributor
Author
|
@chokobole I reflected your comments and added a few new commits. |
chokobole
reviewed
May 15, 2023
3ea0b8d to
b94e5ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remarkable Changes
L2BlockTimein e2e test: 2s to 1se2e/system_test.gol2Syncer→l2SyncreceiptSeq→receiptPropreceiptVerif→receiptSyncforge,forge-stdforge&forge-stdethereum-optimism/optimism#5227op-e2e
op-chain-ops
packages/common-ts
packages/contracts
forge&forge-stdethereum-optimism/optimism#5227foundryversion in CTB README ethereum-optimism/optimism#5250docs