ctb: Update slither config

[maurelian]

Description

• Excludes all findings except for high severity.
• Also moves all slither config to the slither.config.json file.
• I ran slither triage to re-check for all slither detectors and updated the slither db with findings to ignore.
• The slither job is very slow in CI, so I've moved it to its own job and increased the resource class size.
• CI will now fail on high severity slither findings.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d5b6cd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs canceled.

Name	Link
🔨 Latest commit	d5b6cd8
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/642b3508103c150008053d7d

[tynes]

The slither db has absolute paths to files on your filesystem which is kind of strange, meaning its not deterministic between running it on different machines. What is the slither db useful for? To make it deterministic, we would want to run it in a docker image

[maurelian]

What is the slither db useful for?

The db is created when you run slither using --triage-mode.
In triage mode, slither will ask about each finding to determine if it should be shown for the next run. The results of this process are saved in slither.db.json.

The slither db has absolute paths to files on your filesystem which is kind of strange, meaning its not deterministic between running it on different machines.
To make it deterministic, we would want to run it in a docker image

I agree, that is weird and in my experience slither doesn't depend on those values anyways. I think it's fine because triage mode should only ever be run locally.
Rather than forcing people to use docker, I've added a new yarn command to run triage mode, and updated the script so that it will remove these absolute paths from the db. I've done this manually in the past, and slither doesn't seem to depend on having the filename_absolute property in the db anyways.

[trianglesphere]

CI is failing.

[maurelian]

looks like yarn slither is going to time out, not sure why, will need to investigate later.

[trianglesphere]

lgtm. Was waiting for CI to go green.

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.