txgmr,op-batcher,op-proposer: Migrate transaction creation to the txmgr

[trianglesphere]

Description

This consolidates the CraftTx and Send functions in the transaction manger. The transaction manager is now fully responsible for creating & sending transactions.

I did have to reimplement some of the behavior inside the action testing because it is unable to handle blocking the actual proposer.

Tests

Added a test to ensure that the manual packing is the same the expected packing from the contracts. Note that this code is also tested by the devnet & op-e2e which exercise the full withdrawals codepath.

Metadata

• Fixes CLI-3685

TODOs

• Author or reviewer has added an entry to the current release notes draft, if appropriate.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8ade648

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs canceled.

Name	Link
🔨 Latest commit	8ade648
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/641dcb9bf07a3e00081fefad

[codecov]

Codecov Report

Merging #5246 (3b723d6) into develop (0446d83) will decrease coverage by 4.44%.
The diff coverage is 19.67%.

❗ Current head 3b723d6 differs from pull request most recent head 8ade648. Consider uploading reports for the commit 8ade648 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5246      +/-   ##
===========================================
- Coverage    40.34%   35.91%   -4.44%     
===========================================
  Files          372      225     -147     
  Lines        23676    19564    -4112     
  Branches       832        0     -832     
===========================================
- Hits          9552     7026    -2526     
+ Misses       13397    11852    -1545     
+ Partials       727      686      -41     

Flag	Coverage Δ
bedrock-go-tests	35.91% <19.67%> (-0.68%)	⬇️
common-ts-tests	?
contracts-bedrock-tests	?
contracts-tests	?
core-utils-tests	?
dtl-tests	?
fault-detector-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
op-proposer/proposer/l2_output_submitter.go	2.63% <7.31%> (ø)
op-service/txmgr/txmgr.go	79.59% <22.22%> (-2.01%)	⬇️
op-service/txmgr/mocks/TxManager.go	42.30% <60.00%> (-5.52%)	⬇️
op-batcher/batcher/driver.go	5.03% <66.66%> (-0.31%)	⬇️

... and 161 files with indirect coverage changes

[sebastianst]

Looks very good, just one suggestion about improving the abi encoding test.

[protolambda]

LGTM, good refactor

[sebastianst]

Awesome ✨