fix(ci): run tests for common-ts#5220
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
roninjin10
left a comment
There was a problem hiding this comment.
I always find things like this that are broken for long periods of time without anybody noticing very amusing
Tests for common-ts were not being executed in CI because the command being triggered was "yarn test:coverage" and this command was a noop for common-ts. Also fixes a bug in the tests that wasn't caught by CI because of this.
|
Here is the ci run btw for anyone else reviewing https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/15517/workflows/e0094126-1dd0-49dd-91cc-a579e2344011/jobs/547644 |
b6180e5 to
3c58042
Compare
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5220 +/- ##
===========================================
- Coverage 41.24% 41.17% -0.08%
===========================================
Files 306 295 -11
Lines 21569 20554 -1015
Branches 603 350 -253
===========================================
- Hits 8897 8463 -434
+ Misses 12004 11423 -581
Partials 668 668
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Tests for common-ts were not being executed in CI because the command being triggered was "yarn test:coverage" and this command was a noop for common-ts. Also fixes a bug in the tests that wasn't caught by CI because of this.
Metadata