Skip to content

fix(ci): run tests for common-ts#5220

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/cmn-test-coverage
Mar 21, 2023
Merged

fix(ci): run tests for common-ts#5220
mergify[bot] merged 2 commits intodevelopfrom
sc/cmn-test-coverage

Conversation

@smartcontracts
Copy link
Contributor

Description
Tests for common-ts were not being executed in CI because the command being triggered was "yarn test:coverage" and this command was a noop for common-ts. Also fixes a bug in the tests that wasn't caught by CI because of this.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023

⚠️ No Changeset found

Latest commit: 33d10cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 33d10cd
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/641a11edec51730008212633

@mergify mergify bot added the common-ts label Mar 21, 2023
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always find things like this that are broken for long periods of time without anybody noticing very amusing

Tests for common-ts were not being executed in CI because the command
being triggered was "yarn test:coverage" and this command was a noop for
common-ts. Also fixes a bug in the tests that wasn't caught by CI
because of this.
@roninjin10
Copy link
Contributor

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #5220 (33d10cd) into develop (822f588) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5220      +/-   ##
===========================================
- Coverage    41.24%   41.17%   -0.08%     
===========================================
  Files          306      295      -11     
  Lines        21569    20554    -1015     
  Branches       603      350     -253     
===========================================
- Hits          8897     8463     -434     
+ Misses       12004    11423     -581     
  Partials       668      668              
Flag Coverage Δ
bedrock-go-tests 37.71% <ø> (+0.02%) ⬆️
common-ts-tests 26.82% <ø> (?)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes

@mergify mergify bot merged commit cc5a503 into develop Mar 21, 2023
@mergify mergify bot deleted the sc/cmn-test-coverage branch March 21, 2023 20:40
@mergify mergify bot removed the on-merge-train label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

common-ts unit test failed

4 participants