op-e2e: Separate engine API implementation from backend#5335
op-e2e: Separate engine API implementation from backend#5335OptimismBot merged 2 commits intodevelopfrom
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
fc521de to
bcca4dd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5335 +/- ##
===========================================
- Coverage 39.88% 35.52% -4.37%
===========================================
Files 391 238 -153
Lines 25657 21614 -4043
Branches 838 0 -838
===========================================
- Hits 10233 7678 -2555
+ Misses 14644 13194 -1450
+ Partials 780 742 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
protolambda
left a comment
There was a problem hiding this comment.
LGTM, nice cleanup. Regarding non-L2 usage: I think it's a good idea, but also scope-creep, and we can refactor that to be more general in a separate PR.
bcca4dd to
6b9233e
Compare
Moves the engine API implementation to be part of op-program production code
6b9233e to
36c25d3
Compare
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Separate the op-e2e engine API implementation from the backend. The engine API will be used in the fault proof program as well with an oracle based backend.
The engine api implementation has moved to its own module since it will now be production code, not just part of the e2e infrastructure.
Tests
Introduced the
l2_engine_api_tests.gofile which provides a set of tests using a pluggable backend. This tests the engine API code better but also allows testing compatibility with each engine backend, reusing the same tests. Currently the op-e2e backend is all that calls these tests.Metadata
TODOs