Skip to content

Update op-geth with upstream changes from v1.11.5 #5225

Merged
mergify[bot] merged 4 commits intodevelopfrom
aj/update-geth-erszbat
Mar 27, 2023
Merged

Update op-geth with upstream changes from v1.11.5 #5225
mergify[bot] merged 4 commits intodevelopfrom
aj/update-geth-erszbat

Conversation

@ajsutton
Copy link
Contributor

Description

op-chain-ops/genesis: Use actual struct for StateDB instead of interface. The ForEachStorage method has been removed from the interface in geth but is still available on the struct itself.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

⚠️ No Changeset found

Latest commit: e5adb7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit e5adb7f
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642227ee3251670008539011

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #5225 (e5adb7f) into develop (a70a4e3) will decrease coverage by 3.77%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5225      +/-   ##
===========================================
- Coverage    39.90%   36.14%   -3.77%     
===========================================
  Files          382      227     -155     
  Lines        24337    19833    -4504     
  Branches       837        0     -837     
===========================================
- Hits          9711     7168    -2543     
+ Misses       13895    11971    -1924     
+ Partials       731      694      -37     
Flag Coverage Δ
bedrock-go-tests 36.14% <0.00%> (-0.02%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-chain-ops/genesis/check.go 1.30% <0.00%> (ø)

... and 157 files with indirect coverage changes

@ajsutton ajsutton force-pushed the aj/update-geth-erszbat branch from eed2781 to efaff64 Compare March 22, 2023 02:59
@mergify mergify bot added the A-indexer Area: indexer label Mar 22, 2023
@mergify mergify bot requested a review from roninjin10 March 22, 2023 03:00
@tynes
Copy link
Contributor

tynes commented Mar 22, 2023

Hmm not ideal that ForEachStorage was removed from the interface, wonder why

@ajsutton
Copy link
Contributor Author

ajsutton commented Mar 23, 2023

Hmm not ideal that ForEachStorage was removed from the interface, wonder why

Yeah not sure, I suspect because it wasn't actually required by anything using the interface, but similarly there doesn't currently seem to be anything that implements that interface and doesn't have ForEachStorage either.

@ajsutton ajsutton force-pushed the aj/update-geth-erszbat branch 2 times, most recently from aa1399a to 1564dc2 Compare March 26, 2023 22:08
@ajsutton ajsutton marked this pull request as ready for review March 26, 2023 23:16
@ajsutton ajsutton requested review from a team as code owners March 26, 2023 23:16
@ajsutton ajsutton requested review from sebastianst and zhwrd March 26, 2023 23:16
@ajsutton ajsutton force-pushed the aj/update-geth-erszbat branch from 07b083d to 27e3299 Compare March 26, 2023 23:16
@sebastianst sebastianst requested review from protolambda and removed request for sebastianst March 27, 2023 08:03
ajsutton and others added 3 commits March 28, 2023 01:13
@protolambda protolambda force-pushed the aj/update-geth-erszbat branch from 27e3299 to b1c3858 Compare March 27, 2023 23:15
@protolambda
Copy link
Contributor

rebased on develop, and dropped the indexer go.mod changes, and opened #5271 to update the indexer to latest monorepo version cleanly. We can update indexer to geth 1.11.5 cleanly later.

@protolambda protolambda removed request for a team and roninjin10 March 27, 2023 23:19
@protolambda protolambda removed the request for review from zhwrd March 27, 2023 23:19
@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 70da7ad into develop Mar 27, 2023
@mergify mergify bot deleted the aj/update-geth-erszbat branch March 27, 2023 23:55
@mergify mergify bot removed the on-merge-train label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants