Skip to content

op-program: Implement oracle backed engine API backend#5361

Merged
OptimismBot merged 2 commits intodevelopfrom
aj/fpp-engine
Apr 6, 2023
Merged

op-program: Implement oracle backed engine API backend#5361
OptimismBot merged 2 commits intodevelopfrom
aj/fpp-engine

Conversation

@ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Apr 6, 2023

Description

Implements an engine API backend that utilises information from the L2 oracle.

Tests

Reuses the existing engine API tests to verify the integration between the engine API and backend, plus a bunch of unit tests

Metadata

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

⚠️ No Changeset found

Latest commit: 1d673ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 1d673ee
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642ec1f70dc4ab00085c05cd

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #5361 (1d673ee) into develop (b0a2d00) will decrease coverage by 0.78%.
The diff coverage is 81.56%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5361      +/-   ##
===========================================
- Coverage    38.88%   38.10%   -0.78%     
===========================================
  Files          395      241     -154     
  Lines        26402    22014    -4388     
  Branches       838        0     -838     
===========================================
- Hits         10267     8389    -1878     
+ Misses       15354    12854    -2500     
+ Partials       781      771      -10     
Flag Coverage Δ
bedrock-go-tests 38.10% <81.56%> (+2.81%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-program/l2/engine_backend.go 78.51% <78.51%> (ø)
op-program/l2/engineapi/block_processor.go 74.24% <100.00%> (+74.24%) ⬆️
op-program/l2/engineapi/l2_engine_api.go 61.60% <100.00%> (+61.60%) ⬆️
...p-program/l2/engineapi/test/l2_engine_api_tests.go 100.00% <100.00%> (+100.00%) ⬆️

... and 160 files with indirect coverage changes

@ajsutton ajsutton marked this pull request as ready for review April 6, 2023 01:39
@ajsutton ajsutton requested a review from a team as a code owner April 6, 2023 01:39
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants