Skip to content

contracts-bedrock: fee vault withdrawal script#5252

Merged
mergify[bot] merged 3 commits intodevelopfrom
feat/fee-vault-withdrawal-script
Mar 28, 2023
Merged

contracts-bedrock: fee vault withdrawal script#5252
mergify[bot] merged 3 commits intodevelopfrom
feat/fee-vault-withdrawal-script

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Mar 24, 2023

Description

Adds a script for doing FeeVault withdrawals.

Used on goerli to generate this transaction: https://goerli-optimism.etherscan.io/tx/0x2ea5ce60e4fb3826a24611e9ae095754b170ab55e7757dc1dfe6bcd840b219bd

The command for running the script is included in the docstring

@tynes tynes requested a review from a team as a code owner March 24, 2023 17:23
@tynes tynes requested a review from maurelian March 24, 2023 17:23
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

⚠️ No Changeset found

Latest commit: a1117e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit a1117e0
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6423291f8891a9000768787c

@tynes tynes requested a review from clabby March 24, 2023 17:48
@tynes tynes force-pushed the feat/fee-vault-withdrawal-script branch from 32bc20d to c560c9e Compare March 28, 2023 13:50
@tynes
Copy link
Contributor Author

tynes commented Mar 28, 2023

I have addressed all open feedback on this PR

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #5252 (c560c9e) into develop (4d644da) will increase coverage by 20.13%.
The diff coverage is n/a.

❗ Current head c560c9e differs from pull request most recent head a1117e0. Consider uploading reports for the commit a1117e0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5252       +/-   ##
============================================
+ Coverage    19.44%   39.57%   +20.13%     
============================================
  Files          167      346      +179     
  Lines        14891    23185     +8294     
  Branches         0      650      +650     
============================================
+ Hits          2895     9176     +6281     
- Misses       11697    13279     +1582     
- Partials       299      730      +431     
Flag Coverage Δ
bedrock-go-tests 36.14% <ø> (+16.70%) ⬆️
contracts-bedrock-tests 51.32% <ø> (?)
contracts-tests 98.86% <ø> (?)
dtl-tests 47.15% <ø> (?)
sdk-tests 39.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 244 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 84773de into develop Mar 28, 2023
@mergify mergify bot deleted the feat/fee-vault-withdrawal-script branch March 28, 2023 18:39
@mergify mergify bot removed the on-merge-train label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants