contracts-bedrock: fix L2OutputOracle comment#5356
Merged
OptimismBot merged 4 commits intodevelopfrom Apr 7, 2023
Merged
Conversation
The comment mistakenly said that the `pause` functionality would pause both deposits and withdrawals, while it only has the ability to pause withdrawals. The `PostSherlock` deploy script is also updated. We should be able to make the script generic in the future so that it doesn't need to be upgraded over time.
|
✅ Deploy Preview for opstack-docs canceled.
|
maurelian
approved these changes
Apr 5, 2023
Contributor
|
Pushed the commit from #5383 that should unblock this. |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The comment mistakenly said that the
pausefunctionality would pause both deposits and withdrawals, while it only has the ability to pause withdrawals.The
PostSherlockdeploy script is also updated. We should be able to make the script generic in the future so that it doesn't need to be upgraded over time.