Skip to content

txmgr: Configure timeouts better#5283

Merged
mergify[bot] merged 2 commits intodevelopfrom
jg/txmgr_flags
Mar 28, 2023
Merged

txmgr: Configure timeouts better#5283
mergify[bot] merged 2 commits intodevelopfrom
jg/txmgr_flags

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Mar 28, 2023

Description

This adds several flags to control the behavior of the transaction manager a bit better.
This also configures timeouts across all the op-batcher & op-proposer a bit better.

Metadata

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: d956286

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit d956286
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642372a33a35cc0008e21402
😎 Deploy Preview https://deploy-preview-5283--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@trianglesphere trianglesphere marked this pull request as ready for review March 28, 2023 22:45
@trianglesphere trianglesphere requested a review from a team as a code owner March 28, 2023 22:45
@trianglesphere trianglesphere requested a review from ajsutton March 28, 2023 22:45
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #5283 (d956286) into develop (1169788) will decrease coverage by 3.75%.
The diff coverage is 43.47%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5283      +/-   ##
===========================================
- Coverage    39.95%   36.21%   -3.75%     
===========================================
  Files          360      227     -133     
  Lines        22979    19869    -3110     
  Branches       529        0     -529     
===========================================
- Hits          9181     7195    -1986     
+ Misses       13067    11981    -1086     
+ Partials       731      693      -38     
Flag Coverage Δ
bedrock-go-tests 36.21% <43.47%> (+0.06%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-batcher/batcher/config.go 0.00% <ø> (ø)
op-batcher/batcher/driver.go 0.00% <0.00%> (ø)
op-proposer/proposer/config.go 0.00% <ø> (ø)
op-proposer/proposer/l2_output_submitter.go 2.77% <0.00%> (-0.03%) ⬇️
op-proposer/proposer/utils.go 0.00% <ø> (ø)
op-service/txmgr/cli.go 43.07% <54.05%> (+6.88%) ⬆️
op-service/txmgr/txmgr.go 82.06% <66.66%> (-1.09%) ⬇️

... and 134 files with indirect coverage changes

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants