Skip to content

op-e2e: fix p2p gossip flakiness#5369

Merged
trianglesphere merged 1 commit intodevelopfrom
fix-gossip-flake
Apr 6, 2023
Merged

op-e2e: fix p2p gossip flakiness#5369
trianglesphere merged 1 commit intodevelopfrom
fix-gossip-flake

Conversation

@protolambda
Copy link
Contributor

@protolambda protolambda commented Apr 6, 2023

Small test setup fixes:

  • Disable batcher to see L2 gossip effect in isolation. Adjusting the block time doesn't work well when it runs in a laggy environment.
  • Increase timeouts.
  • Only start sequencing after the verifiers are running, to give the verifiers a proper chance of receiving the first few payloads, instead of publishing those while the verifiers might not be fully up and running yet.

@protolambda protolambda requested a review from a team as a code owner April 6, 2023 16:03
@protolambda protolambda requested a review from tynes April 6, 2023 16:03
@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

⚠️ No Changeset found

Latest commit: a6d9364

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit a6d9364
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642f007223c46f0008b67c79

- disable batcher instead of making L1 block time longer
- increase timeouts
- start sequencing after verifiers are ready to receive blocks, to avoid
  missed blocks
@protolambda protolambda changed the title op-e2e: fix p2p gossip flakiness - disable batcher instead of making L1 block time longer op-e2e: fix p2p gossip flakiness Apr 6, 2023
@protolambda
Copy link
Contributor Author

@trianglesphere I found that the verifiers were missing the first few payloads because the sequencer was too quick to publish them, before the verifiers were running. I changed it now to start sequencing only later into the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants