Skip to content

specs: fix finalized L2 blocks description in diagram section#5299

Merged
trianglesphere merged 2 commits intoethereum-optimism:developfrom
node-real:fix_specs
Mar 31, 2023
Merged

specs: fix finalized L2 blocks description in diagram section#5299
trianglesphere merged 2 commits intoethereum-optimism:developfrom
node-real:fix_specs

Conversation

@s7v7nislands
Copy link
Contributor

Description

fix specs about finalized l2 blocks

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

⚠️ No Changeset found

Latest commit: 54651c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 54651c2
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64262cafb8f7810008071455

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #5299 (54651c2) into develop (f738fcf) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5299      +/-   ##
===========================================
+ Coverage    39.92%   39.94%   +0.01%     
===========================================
  Files          382      382              
  Lines        24376    24376              
  Branches       838      838              
===========================================
+ Hits          9732     9736       +4     
+ Misses       13914    13910       -4     
  Partials       730      730              
Flag Coverage Δ
bedrock-go-tests 36.21% <ø> (+0.02%) ⬆️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 51.32% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@sebastianst sebastianst requested review from protolambda and removed request for sebastianst March 30, 2023 15:41
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Simplified it, since in this context it only refers to the case of dervation from finalized input data. This whole section with the diagram is somewhat outdated, thank you for improving it.

@protolambda protolambda changed the title specs: fix finalized l2 blocks specs: fix finalized L2 blocks description in diagram section Mar 30, 2023
Co-authored-by: protolambda <proto@protolambda.com>
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

Hey @s7v7nislands, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@s7v7nislands
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission>=write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants