Skip to content

fix(cmn): BaseServiceV2 throws on camelCase options#5126

Merged
mergify[bot] merged 4 commits intodevelopfrom
inphi/fix-svc
Mar 14, 2023
Merged

fix(cmn): BaseServiceV2 throws on camelCase options#5126
mergify[bot] merged 4 commits intodevelopfrom
inphi/fix-svc

Conversation

@Inphi
Copy link
Contributor

@Inphi Inphi commented Mar 14, 2023

This fixes the BaseServiceV2 ctor throwing with a Error: missing required option: camelCase error.

@Inphi Inphi requested a review from a team as a code owner March 14, 2023 00:42
@Inphi Inphi requested a review from mslipper March 14, 2023 00:42
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

🦋 Changeset detected

Latest commit: fecd42d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/common-ts Patch
@eth-optimism/chain-mon Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot added the common-ts label Mar 14, 2023
@mergify mergify bot requested a review from roninjin10 March 14, 2023 00:42
Co-authored-by: Will Cory <willcory10@gmail.com>
@roninjin10
Copy link
Contributor

Might be worth doing a patch changeset

@Inphi
Copy link
Contributor Author

Inphi commented Mar 14, 2023

will add a changeset in a bit

@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #5126 (fecd42d) into develop (8272207) will decrease coverage by 4.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5126      +/-   ##
===========================================
- Coverage    41.19%   37.02%   -4.18%     
===========================================
  Files          349      220     -129     
  Lines        21317    17545    -3772     
  Branches       776       54     -722     
===========================================
- Hits          8782     6496    -2286     
+ Misses       11866    10417    -1449     
+ Partials       669      632      -37     
Flag Coverage Δ
bedrock-go-tests 36.94% <ø> (+<0.01%) ⬆️
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 130 files with indirect coverage changes

@mergify mergify bot merged commit e251dac into develop Mar 14, 2023
@mergify mergify bot deleted the inphi/fix-svc branch March 14, 2023 01:29
@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants