Skip to content

Generate JSON deploy config from typescript#5276

Merged
mergify[bot] merged 4 commits intodevelopfrom
jm/type-safe-config
Mar 31, 2023
Merged

Generate JSON deploy config from typescript#5276
mergify[bot] merged 4 commits intodevelopfrom
jm/type-safe-config

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Mar 28, 2023 •
edited
Loading

Description

  1. Adds a mainnet-rehearsal network so that we are not continuously modifying the mainnet config.
  2. Adds an hh task for generating a JSON config from a TS file. This allows us to document our reasoning for various config values in the file.

Feedback request:

Should this hh task have an entry in the package.json?

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 741c375

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 741c375
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642722d56f23270008c7f9c1

@maurelian maurelian changed the title Add mainnet deploy config Generate JSON deploy config from typescript Mar 28, 2023
@tynes
Copy link
Contributor

tynes commented Mar 28, 2023

The problem with using mainnet-rehearsal as the network means we will need to copy the mainnet network's deployments in contracts package into a network mainnet-rehearsal and create a network in that package as well

tynes
tynes reviewed Mar 28, 2023
View reviewed changes
tynes
tynes reviewed Mar 28, 2023
View reviewed changes
@maurelian maurelian force-pushed the jm/type-safe-config branch from f7ae289 to 70a0714 Compare March 28, 2023 16:34
@maurelian maurelian marked this pull request as ready for review March 28, 2023 16:34
@maurelian maurelian requested a review from a team as a code owner March 28, 2023 16:34
@maurelian maurelian requested a review from clabby March 28, 2023 16:34
@maurelian
Copy link
Contributor Author

maurelian commented Mar 28, 2023 •
edited
Loading

The problem with using mainnet-rehearsal as the network means we will need to copy the mainnet network's deployments in contracts package into a network mainnet-rehearsal and create a network in that package as well

oh, that's ugly. I will revert to using mainnet, but use the new ability to add comments to the config to clarify.

@maurelian maurelian force-pushed the jm/type-safe-config branch 2 times, most recently from c16f087 to 11ae400 Compare March 28, 2023 18:24
@maurelian maurelian requested a review from tynes March 28, 2023 18:25
@tynes
Copy link
Contributor

tynes commented Mar 30, 2023

Good to merge after linting errors are fixed

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Mar 30, 2023
@maurelian maurelian force-pushed the jm/type-safe-config branch 3 times, most recently from d07dba9 to 3256f5c Compare March 30, 2023 20:30
mslipper and others added 4 commits March 31, 2023 14:13
@mslipper @maurelian
Add mainnet deploy config
f954a58 
update timestamps + start hash

use string for regolith

add tag

update parameters

contracts-bedrock: commit updated deploy config
@maurelian
feat(ctb): Add portalGuardian to mainnet config
2e06e54
@maurelian
feat(ctb): Add type safety to deploy-config
6db6676
@maurelian
feat(ctb): generate deploy config
741c375
@maurelian maurelian force-pushed the jm/type-safe-config branch from 3256f5c to 741c375 Compare March 31, 2023 18:13
@mergify mergify bot merged commit c777bf5 into develop Mar 31, 2023
@mergify mergify bot deleted the jm/type-safe-config branch March 31, 2023 18:34
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@seolaoh seolaoh mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@clabby clabby Awaiting requested review from clabby clabby is a code owner automatically assigned from ethereum-optimism/contract-reviewers

+1 more reviewer

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maurelian @tynes @mslipper