Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
Prepares for adding in L2 deployment scripts by adding a `l1` tag to the deploy scripts that should run on L1. Also add the tag flag to the deployment that happens in CI. The L2 contract deployments will be added in another commit. It is not a problem if the L2 contracts are deployed to L1 in a testing environment but using tags to save time and gas should be done. Also lints a few lines of code where awaits are nested, nested awaits are difficult to read.
tynes
force-pushed
the
feat/l1-deploy-tag
branch
from
8b27f29 to
0236d9e
Compare
maurelian
approved these changes
Mar 31, 2023
Contributor
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
This is good for me, though I am slightly confused about why it is necessary. All of these scripts are specific to L1.
Contributor
Author
|
L2 deployments coming soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepares for adding in L2 deployment scripts by adding a
l1tag to the deploy scripts that should run on L1. Also add the tag flag to the deployment that happens in CI. The L2 contract deployments will be added in another commit. It is not a problem if the L2 contracts are deployed to L1 in a testing environment but using tags to save time and gas should be done. Also lints a few lines of code where awaits are nested, nested awaits are difficult to read.