[jdx]

https://entire.io/gh/jdx/mise/trails/464

Summary

Updates sigstore-verify from 0.11 to 0.14 and ports mise-sigstore to the new API. This replaces the Renovate PR #13995, which can't compile on its own because 0.14 is a breaking release. There is no user-visible behavior change: attestation, cosign and SLSA verification keep the same trust decisions.

API changes handled:

• TUF mirror override — TufConfig::custom now takes a TufBootstrap; the mirror still bootstraps from the embedded production root (SigstoreInstance::PublicGood.tuf_root()). DEFAULT_TUF_URL is no longer exported, so mise-sigstore defines it.
• Verification policy — VerificationPolicy has no Default; mise uses any_identity() and keeps authorizing the signer itself via the existing workflow check. skip_tlog is now skip_tlog_unsafe, applied only when the bundle has no inclusion proof (same as before). verify_with_key takes an explicit PublicKeyVerificationPolicy::default() (tlog verified, as before).
• DSSE / keys — envelopes carry exactly one signature (envelope.signature, payload.as_bytes()); key type detection uses KeyAlgorithm::from_spki, still accepting only Ed25519 and ECDSA P-256.

Testing

cargo test -p mise-sigstore (54 pass) and cargo +stable clippy --workspace --all-features --all-targets -- -D warnings are clean.

Supersedes #13995.

🤖 Generated with Claude Code

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.

---

Note

Medium Risk
Changes sit on attestation, cosign, and SLSA verification paths; the diff is mostly an API port, but reviewers should confirm policy choices still match 0.11 behavior.

Overview
Bumps sigstore-verify from 0.11 to 0.14 in mise-sigstore (with matching Cargo.lock churn for the sigstore crate graph and transitive bumps like windows-sys). This is a compile-fix for the breaking 0.14 release, not a feature change.

mise-sigstore is updated to match the new API while keeping the same verification rules: VerificationPolicy::any_identity() plus the existing workflow identity check; skip_tlog_unsafe() only when a bundle has no Rekor inclusion proof; skip_sct() for GitHub-internal certs; and PublicKeyVerificationPolicy::default() on verify_with_key. TUF mirror overrides now use TufConfig::custom(url, TufBootstrap::trusted(...)) instead of with_root(PRODUCTION_TUF_ROOT), and DEFAULT_TUF_URL is defined locally because 0.14 no longer exports it.

DSSE handling follows the new envelope shape (payload.as_bytes(), single envelope.signature), cosign key detection uses KeyAlgorithm::from_spki, bundle validation uses ValidationOptions::new(), and TrustedRoot::fulcio_certs() is used without the old Result wrapper. Tests were adjusted for the TufConfig debug/URL assertions.

^{Reviewed by Cursor Bugbot for commit 91b26fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Improvements
  • Updated Sigstore verification for current signing and attestation formats.
  • Bundles with an inclusion proof continue to undergo transparency-log verification; bundles without one can be verified without that check.
  • TUF mirror overrides continue to use the embedded production trust root, while the default production configuration remains unchanged.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	cargo/​sigstore-verify@​0.14.0

View full report

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 46718dd9-4e56-4706-980d-772bd2354009

📥 Commits

Reviewing files that changed from the base of the PR and between 53e16d5 and 91b26fc.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (8)

• crates/mise-sigstore/Cargo.toml
• crates/mise-sigstore/src/bundle.rs
• crates/mise-sigstore/src/certificate.rs
• crates/mise-sigstore/src/cosign.rs
• crates/mise-sigstore/src/lib.rs
• crates/mise-sigstore/src/slsa.rs
• crates/mise-sigstore/src/tests/certificate.rs
• crates/mise-sigstore/src/trust.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

---

📝 Walkthrough

Walkthrough

The Sigstore verification dependency and related API calls are updated. Bundle verification policies change, DSSE payload consumers use envelope bytes directly, and custom TUF configurations use the public-good instance root.

Changes

Sigstore verification

Layer / File(s)	Summary
Verification API and policies crates/mise-sigstore/Cargo.toml, crates/mise-sigstore/src/bundle.rs, crates/mise-sigstore/src/cosign.rs	The sigstore-verify dependency advances from 0.11 to 0.14. Bundle verification uses any_identity() and skips tlog verification without an inclusion proof. Bundle and raw-signature verification use updated key APIs, and SHA-256 digest conversion uses TryFrom.
DSSE payload processing crates/mise-sigstore/src/certificate.rs, crates/mise-sigstore/src/cosign.rs, crates/mise-sigstore/src/slsa.rs	Repository extraction and subject verification receive the envelope payload bytes directly. DSSE verification builds PAE from those bytes and verifies the envelope’s single signature.sig.
TUF configuration and tests crates/mise-sigstore/src/lib.rs, crates/mise-sigstore/src/trust.rs, crates/mise-sigstore/src/tests/certificate.rs	The crate defines DEFAULT_TUF_URL locally. Custom URL configuration uses a trusted bootstrap with SigstoreInstance::PublicGood.tuf_root(). Tests check the default and mirror URLs in the selected configuration’s debug representation.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 91b26

No actionable merge-blocking risk is established; the update is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 7 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: updating the sigstore-verify Rust crate to version 0.14.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 7 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[High risk] Updates cryptographic signature verification library.

The PR appears safe to merge; no actionable defect was established.

What we checked:

• Requested workflows still get checked: The wrapper still passes the verified identity to verify_signer_workflow_identity. That function rejects missing identities and workflows that do not match.

Summary

Updates sigstore-verify from 0.11 to 0.14 and adapts mise-sigstore to its new API.

• Uses the new verification policies, key detection, and DSSE fields.
• Supplies the embedded production root when configuring a TUF mirror.
• Keeps explicit signer checks and artifact digest checks.
• No actionable issue was established. Tests were not run during this review.

_{Reviews (1) · Last reviewed commit: "fix(deps): update rust crate sigstore-ve..."}

[github-actions]

Instruction counts

benchmark	trend	instructions	Δ	wall (min)	Δ
env	▁▃▁▃▃▁▆█▆	27,244,123 → 27,223,779	-0.07%	19.19 → 19.46ms	+1.41%
hook-env	▃▁▃▄▄▅▅▇█	29,215,570 → 29,236,628	+0.07%	20.01 → 20.43ms	+2.13%
ls	▂▃▁▄██▃█▁	30,930,818 → 30,855,379	-0.24%	21.03 → 21.01ms	-0.10%
registry	▂▁▁▁▂▂▂█▇	40,168,801 → 40,130,840	-0.09%	17.50 → 17.85ms	+1.96%
startup	▁▁▁▃▃▂▆██	10,868,035 → 10,869,526	+0.01%	12.02 → 12.24ms	+1.81%

No instruction-count regression above 1%.

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{91b26fc896ba vs 53e16d593c4c · measured on the runner, not pushed to the history.}