Repository navigation
fix(deps): update rust crate sigstore-verify to 0.14 - autoclosed - #13995
Closed
renovate[bot] wants to merge 1 commit into
Closed
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
Contributor
|
This PR does not match any of the 1 configured review trigger rule. |
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
renovate
Bot
force-pushed
the
renovate/sigstore-crates
branch
from
October 6, 2026 14:59
0cbb54d to
8cfcc1e
Compare
jdx
added a commit
that referenced
this pull request
Oct 6, 2026
<!-- entire-trail-link-start --> https://entire.io/gh/jdx/mise/trails/464 <!-- entire-trail-link-end --> ## Summary Updates `sigstore-verify` from 0.11 to 0.14 and ports `mise-sigstore` to the new API. This replaces the Renovate PR #13995, which can't compile on its own because 0.14 is a breaking release. There is no user-visible behavior change: attestation, cosign and SLSA verification keep the same trust decisions. API changes handled: - **TUF mirror override** — `TufConfig::custom` now takes a `TufBootstrap`; the mirror still bootstraps from the embedded production root (`SigstoreInstance::PublicGood.tuf_root()`). `DEFAULT_TUF_URL` is no longer exported, so `mise-sigstore` defines it. - **Verification policy** — `VerificationPolicy` has no `Default`; mise uses `any_identity()` and keeps authorizing the signer itself via the existing workflow check. `skip_tlog` is now `skip_tlog_unsafe`, applied only when the bundle has no inclusion proof (same as before). `verify_with_key` takes an explicit `PublicKeyVerificationPolicy::default()` (tlog verified, as before). - **DSSE / keys** — envelopes carry exactly one signature (`envelope.signature`, `payload.as_bytes()`); key type detection uses `KeyAlgorithm::from_spki`, still accepting only Ed25519 and ECDSA P-256. ## Testing `cargo test -p mise-sigstore` (54 pass) and `cargo +stable clippy --workspace --all-features --all-targets -- -D warnings` are clean. Supersedes #13995. 🤖 Generated with [Claude Code](https://claude.com/claude-code) *AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.* <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes sit on attestation, cosign, and SLSA verification paths; the diff is mostly an API port, but reviewers should confirm policy choices still match 0.11 behavior. > > **Overview** > Bumps **`sigstore-verify`** from **0.11** to **0.14** in `mise-sigstore` (with matching **`Cargo.lock`** churn for the sigstore crate graph and transitive bumps like **`windows-sys`**). This is a compile-fix for the breaking 0.14 release, not a feature change. > > **`mise-sigstore`** is updated to match the new API while keeping the same verification rules: **`VerificationPolicy::any_identity()`** plus the existing workflow identity check; **`skip_tlog_unsafe()`** only when a bundle has no Rekor inclusion proof; **`skip_sct()`** for GitHub-internal certs; and **`PublicKeyVerificationPolicy::default()`** on **`verify_with_key`**. TUF mirror overrides now use **`TufConfig::custom(url, TufBootstrap::trusted(...))`** instead of **`with_root(PRODUCTION_TUF_ROOT)`**, and **`DEFAULT_TUF_URL`** is defined locally because 0.14 no longer exports it. > > DSSE handling follows the new envelope shape (**`payload.as_bytes()`**, single **`envelope.signature`**), cosign key detection uses **`KeyAlgorithm::from_spki`**, bundle validation uses **`ValidationOptions::new()`**, and **`TrustedRoot::fulcio_certs()`** is used without the old **`Result`** wrapper. Tests were adjusted for the **`TufConfig`** debug/URL assertions. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 91b26fc. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Improvements** * Updated Sigstore verification for current signing and attestation formats. * Bundles with an inclusion proof continue to undergo transparency-log verification; bundles without one can be verified without that check. * TUF mirror overrides continue to use the embedded production trust root, while the default production configuration remains unchanged. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
auto-merge was automatically disabled
October 6, 2026 16:47
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/jdx/mise/trails/447
This PR contains the following updates:
0.11→0.14Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
sigstore/sigstore-rust (sigstore-verify)
v0.14.0Compare Source
Added
Other
v0.13.0Compare Source
Fixed
v0.12.0Compare Source
Added
Fixed
jiffTimestamp in the interfaces (#164)Other
Configuration
📅 Schedule: (in timezone America/Chicago)
* * * * 2)🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.