-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v7.16.0 #1675
Merged
Merged
Release v7.16.0 #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is like the metadata delegate, but for feature flags. It holds a common API for both Client & Event to use
…er-tests Browser maze runner tests for feature flags
Originally it seemed like we'd only need this in the Event class, however it's also necessary in Electron when sending flags to the native client Therefore this needs to be somewhere reusable, i.e. the feature flag delegate
This event isn't consumed yet, as that requires changes to the native client to support it
…o-delegate Move Event API conversion to feature flag delegate
…lient Add feature flags support to the Electron native client
…-update Use feature-flag steps in Browser feature flag tests
Add support for feature flags in "clone client"
…tests Expo Maze Runner tests for feature flags
…tests Add maze runner tests for feature flags in node
Renderer processes will now contain all feature flags from the main process, both those added as config and with Bugsnag.addFeatureFlag(s)
This is deprecated in favour of Application.nativeBuildVersion Application.nativeBuildVersion seems equivalent for iOS as well, so I've switched both platforms to use it
Migrate macos 10.15 steps to macos 11
…native-tests Mazerunner tests for React Native feature flags in native code
Expo: avoid using deprecated constants
Update integration/feature-flags with latest next
# Conflicts: # packages/react-native/ios/.bugsnag-cocoa-version # packages/react-native/ios/BugsnagReactNative/BugsnagReactNativeEmitter.m # packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/Client/BugsnagClient.m # packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/Configuration/BugsnagConfiguration.m # packages/react-native/ios/vendor/bugsnag-cocoa/CHANGELOG.md
Sync FeatureFlags integration branch with next
Feature Flags
|
Minified | Minfied + Gzipped | |
---|---|---|
Before | 41.58 kB |
12.80 kB |
After | 42.85 kB |
13.07 kB |
± | +1,275 bytes |
+268 bytes |
code coverage diff
Ok | File | Lines | Branches | Functions | Statements |
---|---|---|---|---|---|
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/client.js | 99.38% (+0.03%) |
97.65% (+0.03%) |
100% (+0%) |
98.86% (+0.06%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/config.js | 100% (+0%) |
98.33% (+0.15%) |
100% (+0%) |
98.57% (+0.06%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/event.js | 95.5% (+0.26%) |
88.52% (+0.19%) |
100% (+0%) |
95.8% (+0.22%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/lib/feature-flag-delegate.js | 100% (+100%) |
100% (+100%) |
100% (+100%) |
100% (+100%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-client-state-manager/client-state-manager.js | 100% (+0%) |
83.33% (+3.33%) |
100% (+0%) |
100% (+0%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-client-state-persistence/client-state-persistence.js | 89.29% (+2.33%) |
100% (+0%) |
87.5% (+1.79%) |
89.29% (+2.33%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-deliver-minidumps/deliver-minidumps.js | 50.82% (+0.82%) |
43.75% (+0%) |
33.33% (+0%) |
51.52% (+0.75%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-ipc/bugsnag-ipc-main.js | 82.81% (+0.27%) |
73.08% (+0%) |
89.47% (+0%) |
81.69% (+0.26%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-ipc/bugsnag-ipc-renderer.js | 96.3% (+0.65%) |
100% (+0%) |
95% (+1.25%) |
96.43% (+0.6%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-renderer-event-data/renderer-event-data.js | 90% (+0.53%) |
81.25% (+0%) |
100% (+0%) |
90.91% (+0.43%) |
🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-expo-app/app.js | 96.55% (+0.12%) |
93.75% (-1.25%) |
100% (+0%) |
96.55% (+0.12%) |
🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-expo-device/device.js | 100% (+0%) |
90% (-1.67%) |
100% (+0%) |
100% (+0%) |
🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-react-native-client-sync/client-sync.js | 85.51% (-5.19%) |
47.06% (-25.67%) |
100% (+0%) |
85.92% (-5.19%) |
✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/react-native/src/notifier.js | 72.84% (+0.69%) |
65.79% (+4.03%) |
61.54% (+0%) |
71.91% (+0.65%) |
Total:
Lines | Branches | Functions | Statements |
---|---|---|---|
81.89%(+0.31%) | 71.44%(+0.08%) | 83.08%(+0.41%) | 80.96%(+0.31%) |
djskinner
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
bugsnag-cocoa#1279
CLANG_ENABLE_MODULES=NO
bugsnag-cocoa#1284
bugsnag-cocoa#1274
bugsnag-cocoa#1273
bugsnag-cocoa#1281
bugsnag-cocoa#1263
OnSendError
callbacks if delivery needs to be retried.bugsnag-cocoa#1262
device.freeDisk
in crash errors.bugsnag-cocoa#1256
bugsnag-cocoa#1252
CLANG_ENABLE_MODULES=NO
bugsnag-cocoa#1284