Add support for feature flags in "clone client" #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 42.81 kB |
13.06 kB |
| After | 42.81 kB |
13.06 kB |
| ± | No change | No change |
code coverage diff
Coverage values did not change👌.
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.74%(+0.01%) | 72.13%(+0%) | 83.87%(+0%) | 81.72%(+0%) |
djskinner
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The clone client function is used in session tracking and node server integrations to prevent changes from always being global (e.g. this allows per-request metadata)
Feature flags may also differ between requests (e.g. each user may have a different set of flags), so we need to clone them as well