Mazerunner tests for React Native feature flags in native code #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,3 +42,32 @@ Scenario: Sends no feature flags after clearFeatureFlags() | |||
| And the exception "errorClass" equals "Error" | |||
| And the event "unhandled" is false | |||
| And event 0 has no feature flags | |||
|
|
|||
| Scenario: Sends JS feature flags in a native crash | |||
| When I run "FeatureFlagsNativeCrashScenario" and relaunch the app | |||
There was a problem hiding this comment.
Ah, we're going to have a problem here as I have renamed the step on next - apologies. Could you update the integration branch and this PR first? The step now says "...and relaunch the crashed app".
Otherwise the build of next will just fail after the integration branch gets merged.
There was a problem hiding this comment.
Actually, ignore that, there are most likely other test scenarios that are affected. Let's merge this and update the integration branch as a separate activity.
twometresteve
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensure that React Native feature flags are included in reports generated when native code (JVM / Cocoa) crashes are reported. Any changes made to feature flags in JavaScript should be visible in native reports, and changes made to feature flags from native code should be visible in JavaScript reports.
Testing
Added new Mazerunner scenarios