Add feature flags support to the Electron native client #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event isn't consumed yet, as that requires changes to the native client to support it
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 42.51 kB |
12.98 kB |
| After | 42.51 kB |
12.98 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-client-state-manager/client-state-manager.js | 100% (+0%) |
83.33% (+3.33%) |
100% (+0%) |
100% (+0%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-client-state-persistence/client-state-persistence.js | 89.29% (+2.33%) |
100% (+0%) |
87.5% (+1.79%) |
89.29% (+2.33%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.79%(+0.12%) | 72.22%(+0.03%) | 83.87%(+0.08%) | 81.76%(+0.11%) |
kattrali
approved these changes
Nov 5, 2021
Base automatically changed from
feature-flags/move-formatting-to-delegate
to
integration/feature-flags
November 9, 2021 10:29
lemnik
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds wrapper methods to the feature flag API on the main process client to sync feature flags to the native client
We don't support partial updates; the feature flags are always replaced entirely when
NativeClient.updateFeatureFlagsis calledTesting
Relies on unit tests as the rest of Electron doesn't support feature flags, so this can't be tested end to end yet