Expo: avoid using deprecated constants #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constants.isDevice has been deprecated
This is deprecated in favour of Application.nativeBuildVersion Application.nativeBuildVersion seems equivalent for iOS as well, so I've switched both platforms to use it
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.58 kB |
12.80 kB |
| After | 41.58 kB |
12.80 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-expo-app/app.js | 96.55% (+0.12%) |
93.75% (-1.25%) |
100% (+0%) |
96.55% (+0.12%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-expo-device/device.js | 100% (+0%) |
90% (-1.67%) |
100% (+0%) |
100% (+0%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 81.58%(+0%) | 71.26%(-0.1%) | 82.67%(+0%) | 80.66%(+0.01%) |
djskinner
approved these changes
Jan 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR migrates away from a number of deprecated constants, notably fixing a deprecation warning from
Constants.platform.ios.modelraised in the current version of@bugsnag/expoConstants.platform.ios.modelDevice.modelNameConstants.platform.android.versionCodeApplication.nativeBuildVersionConstants.platform.ios.buildNumber1Application.nativeBuildVersionConstants.platform.ios.platformDevice.modelIdConstants.platform.ios.systemVersionDevice.osVersionConstants.isDeviceDevice.isDeviceFootnotes
This isn't actually deprecated, but
Application.nativeBuildVersionis equivalent and it seemed sensible to use the same value for both iOS & Android ↩