Move Event API conversion to feature flag delegate #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally it seemed like we'd only need this in the Event class, however it's also necessary in Electron when sending flags to the native client Therefore this needs to be somewhere reusable, i.e. the feature flag delegate
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 42.49 kB |
12.97 kB |
| After | 42.51 kB |
12.98 kB |
| ± | +21 bytes |
+11 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/event.js | 95.5% (-0.26%) |
88.52% (-0.37%) |
100% (+0%) |
95.8% (-0.23%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 0%(+0%) | 0%(+0%) | 0%(+0%) | 0%(+0%) |
djskinner
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This is a small refactor to move the function that converts feature flags into the Event API format to the feature flag delegate. Originally it seemed like we'd only need this in the Event class, however it's also necessary in Electron when sending flags to the native client so needs to be somewhere reusable
Testing
A few new tests have been added, but this is also covered by existing unit tests for
Event#toJSON