Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6816] Detect hangs during launch of scene based apps #1263

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Detect hangs during launch of scene based apps.

UIScene-based apps are launched with a background UIApplicationState - the state changes to foreground when the first scene is created.

Changeset

Enables detection of hangs between Bugsnag.start() and the first turn of the run loop regardless of the reported application state.

This means that hangs during the launch of background sessions will also be detected - no way to determine between foreground and background launches was found for scene based apps.

Once the run loop has run we expect the app state to be accurate.

Testing

Tested locally using a sample app.

@github-actions
Copy link

github-actions bot commented Dec 20, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size increased by 456 bytes from 1,255,440 to 1,255,896

Generated by 🚫 Danger

Bugsnag/Helpers/BSGAppHangDetector.m Outdated Show resolved Hide resolved
@nickdowell nickdowell force-pushed the nickdowell/fix-scene-launch-hang-detection branch from d018143 to b9fea65 Compare January 4, 2022 13:33
@nickdowell nickdowell merged commit accc792 into next Jan 4, 2022
@nickdowell nickdowell deleted the nickdowell/fix-scene-launch-hang-detection branch January 4, 2022 16:20
@nickdowell nickdowell mentioned this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants