Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use feature-flag steps in Browser feature flag tests #1574

Merged

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Nov 9, 2021

Goal

Uses the generic feature flag steps in browser feature flag e2e testing.

In addition seems like this is the first time the Gemfile.lock has been updated since maze-runner was removed from the top level Gemfile. This isn't required at all, but I don't think it's an issue.

@Cawllec Cawllec requested a review from imjoehaines November 9, 2021 10:14
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 42.79 kB 13.04 kB
After 42.79 kB 13.04 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 2534024

@imjoehaines imjoehaines merged commit 3798a22 into integration/feature-flags Nov 9, 2021
@imjoehaines imjoehaines deleted the feature-flags-browser-test-step-update branch November 9, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants