[PLAT-7722] Include free disk space in crash reports #1256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Make
device.freeDisk
accurate for crashes.Currently crash errors report the disk space available at the time of sending.
Changeset
NSFileSystemFreeSize
.BSG_KSSystemInfo
- this gets used for handled errors.Async safety
This PR adds a call to
fstat()
in the crash handler.This function is not documented as being async-safe but should be by virtue of being implemented as a syscall.
Testing
Manually verified that the calculated free space matches
NSFileSystemFreeSize
.E2E tests verify that
freeDisk
is present in all types of error.