Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maze runner tests for feature flags in node #1589

Merged

Conversation

imjoehaines
Copy link
Contributor

Goal

Adds some maze runner tests for feature flags to the Node test suite. These focus on the request-scoped client having separate lists of feature flags (so each request can have their own set of flags), while also ensuring global flags are supported

@imjoehaines imjoehaines requested a review from a team November 19, 2021 09:16
@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 42.81 kB 13.06 kB
After 42.81 kB 13.06 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 736cd39

Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imjoehaines imjoehaines merged commit 543d95a into integration/feature-flags Nov 19, 2021
@imjoehaines imjoehaines deleted the feature-flags/node-maze-runner-tests branch November 19, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants