[PLAT-7756] Omit unused binary_images in KSCrashReports #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
nickdowell
force-pushed
the
nickdowell/omit-binary-images
branch
from
5b22190 to
bf3d451
Compare
kstenerud
approved these changes
Jan 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve performance and storage requirements of writing a crash report.
Changeset
struct bsg_mach_imagewhich is used to track which images are referenced by the crash's stack traces.binary_images.Testing
Shows a ~30% speedup in
testWriteStandardReportPerformance.Added a unit test case to verify that only the expected binary images are included.
Existing E2E tests ensure that required image info is included - missing images would result in no
machoFileetc. in the Bugsnag payload, which is checked for in our tests.