Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing user.id in session-less OOMs #1274

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix missing user.id in session-less OOMs #1274

merged 1 commit into from
Jan 10, 2022

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Jan 10, 2022 •
edited
Loading

Goal

Make OOM events include user information even if there was no active session.

Changeset

  • Ensures the correct configuration object (that includes the auto-generated user id) is serialised to disk at start-up
  • Uses the serialized user info for OOM events if there is no session.user

Testing

Added an E2E scenario that triggered the problem and verified the fix.

@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,255,896 bytes

Generated by 🚫 Danger

@nickdowell nickdowell force-pushed the nickdowell/fix-oom-user-id branch from 57bb09d to 8f2a1cf Compare January 10, 2022 13:47
@nickdowell nickdowell changed the title Fix missing fallback user id for for OOM events Fix missing user.id in session-less OOMs Jan 10, 2022
@kstenerud kstenerud self-requested a review January 10, 2022 14:37
@nickdowell nickdowell merged commit ab774f3 into next Jan 10, 2022
@nickdowell nickdowell deleted the nickdowell/fix-oom-user-id branch January 10, 2022 15:00
@nickdowell nickdowell mentioned this pull request Jan 12, 2022
Merged
@imjoehaines imjoehaines mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

@kattrali kattrali Awaiting requested review from kattrali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @kstenerud