Expo Maze Runner tests for feature flags #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
commented
Nov 9, 2021
Comment on lines
+67
to
+70
| // reset the bugsnag client so tests don't interfere wtih eachother | ||
| bugsnagClient.clearFeatureFlags() | ||
| bugsnagClient.removeOnError(addFeatureFlagsOnError) | ||
| bugsnagClient.removeOnError(clearFeatureFlagsOnError) |
There was a problem hiding this comment.
We don't relaunch the app between tests (or if we do that doesn't reset the notifier) so feature flags and callbacks added in previous tests will stick around
I don't think it's possible to use a new client for this because of unhandled exceptions. If both clients report unhandled exceptions then the tests are flakey because sometimes you'll get two events (one from each client). If we create a new client to attach feature flags to, unhandled exceptions won't be sent with those flags because they're on the wrong client
Cawllec
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds some maze runner tests for feature flags to the Expo test suite