Browser maze runner tests for feature flags #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cawllec
approved these changes
Nov 4, 2021
| And the error is a valid browser payload for the error reporting API | ||
| And event 0 is handled | ||
| And the error payload field "events.0.featureFlags" is an array with 8 elements | ||
| And the event "featureFlags.0.featureFlag" equals "from config 1" |
There was a problem hiding this comment.
We could simplify this with a new step that consumes a table and applies its contents across the featureFlags. That way this could also be unordered which would remove a source of flakiness.
For now, provided we think flakes due to the ordering of feature flags are unlikely, I propose we raise a ticket to add said step to Maze-runner for future use in this and other notifiers.
Proposed table would look something like:
| featureFlag | variant |
|--------------|----------------|
| from config 1 | 1234 |
| from config 2 | |
etc
| @@ -41,3 +41,15 @@ | |||
| txt = Maze.driver.find_element(id: 'bugsnag-test-state').text | |||
| assert_equal('DONE', txt, "Expected #bugsnag-test-state text to be 'DONE'. It was '#{txt}'.") | |||
| end | |||
|
|
|||
| Then("the event {string} has no variant") do |field_path| | |||
There was a problem hiding this comment.
As mentioned above we should add some steps to maze-runner core to perform these steps unless they're going to seriously vary between each notifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds some maze runner tests for feature flags to the browser test suite