Feature Flags #1670
Merged
Feature Flags #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is like the metadata delegate, but for feature flags. It holds a common API for both Client & Event to use
…er-tests Browser maze runner tests for feature flags
Originally it seemed like we'd only need this in the Event class, however it's also necessary in Electron when sending flags to the native client Therefore this needs to be somewhere reusable, i.e. the feature flag delegate
This event isn't consumed yet, as that requires changes to the native client to support it
…o-delegate Move Event API conversion to feature flag delegate
…lient Add feature flags support to the Electron native client
…-update Use feature-flag steps in Browser feature flag tests
Add support for feature flags in "clone client"
…tests Expo Maze Runner tests for feature flags
…tests Add maze runner tests for feature flags in node
Renderer processes will now contain all feature flags from the main process, both those added as config and with Bugsnag.addFeatureFlag(s)
…-in-renderer-crashes Fix feature flags being missing from renderer crashes
Allow `featureFlags` in ReactNative config
…next Merge branch 'next' into integration/feature-flags
# Conflicts: # test/browser/Gemfile # test/browser/Gemfile.lock # test/expo/Gemfile # test/expo/Gemfile.lock # test/node/Gemfile # test/node/Gemfile.lock
Merge next into Feature Flags
…-android Sync ReactNative feature flags on Android
Sync ReactNative feature flags on iOS
…native-tests Mazerunner tests for React Native feature flags in native code
Update integration/feature-flags with latest next
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.58 kB |
12.80 kB |
| After | 42.85 kB |
13.07 kB |
| ± | +1,275 bytes |
+268 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/client.js | 99.38% (+0.03%) |
97.65% (+0.03%) |
100% (+0%) |
98.86% (+0.06%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/config.js | 100% (+0%) |
98.33% (+0.15%) |
100% (+0%) |
98.57% (+0.06%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/event.js | 95.5% (+0.26%) |
88.52% (+0.19%) |
100% (+0%) |
95.8% (+0.22%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/lib/feature-flag-delegate.js | 100% (+100%) |
100% (+100%) |
100% (+100%) |
100% (+100%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-client-state-manager/client-state-manager.js | 100% (+0%) |
83.33% (+3.33%) |
100% (+0%) |
100% (+0%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-client-state-persistence/client-state-persistence.js | 89.29% (+2.33%) |
100% (+0%) |
87.5% (+1.79%) |
89.29% (+2.33%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-deliver-minidumps/deliver-minidumps.js | 50.82% (+0.82%) |
43.75% (+0%) |
33.33% (+0%) |
51.52% (+0.75%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-ipc/bugsnag-ipc-main.js | 82.81% (+0.27%) |
73.08% (+0%) |
89.47% (+0%) |
81.69% (+0.26%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-ipc/bugsnag-ipc-renderer.js | 96.3% (+0.65%) |
100% (+0%) |
95% (+1.25%) |
96.43% (+0.6%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-renderer-event-data/renderer-event-data.js | 90% (+0.53%) |
81.25% (+0%) |
100% (+0%) |
90.91% (+0.43%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-react-native-client-sync/client-sync.js | 85.51% (-5.19%) |
47.06% (-25.67%) |
100% (+0%) |
85.92% (-5.19%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/react-native/src/notifier.js | 72.84% (+0.69%) |
65.79% (+4.03%) |
61.54% (+0%) |
71.91% (+0.65%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 81.89%(+0.31%) | 71.44%(+0.18%) | 83.08%(+0.41%) | 80.96%(+0.3%) |
# Conflicts: # packages/react-native/ios/.bugsnag-cocoa-version # packages/react-native/ios/BugsnagReactNative/BugsnagReactNativeEmitter.m # packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/Client/BugsnagClient.m # packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/Configuration/BugsnagConfiguration.m # packages/react-native/ios/vendor/bugsnag-cocoa/CHANGELOG.md
Sync FeatureFlags integration branch with next
tomlongridge
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
This needs a changelog entry for the release, but happy to add it later rather than re-do the CI. (See Android release notes for wording.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Merges the feature flags integration branch into next.