feat: non-blocking and centralized progress reporting #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
May 23, 2025
jreidinger
reviewed
May 23, 2025
jreidinger
reviewed
May 23, 2025
jreidinger
reviewed
May 23, 2025
jreidinger
approved these changes
May 23, 2025
imobachgs
added a commit
that referenced
this pull request
May 23, 2025
Fix a wrong call to start_progress_with_descriptions (introduced in #2389).
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 27, 2025
https://build.opensuse.org/request/show/1280489 by user IGonzalezSosa + anag_factory - Version 15 - Proper handling of WebSocket secure connections (gh#agama-project/agama#2391): - "agama monitor" does not use "insecure" by default. - Do not encrypt the connection when using ws: URLs. - Cache progress reporting to avoid blocking the clients (gh#agama-project/agama#2389). - Update schema of the storage model (gh#agama-project/agama#2346). - Provide software conflicts HTTP API (gh#agama-project/agama#2348) - Cache issues to avoid blocking the clients (gh#agama-project/agama#2379). - Cache the software configuration and products in the web server, the software backend is blocked during package installation (bsc#1241208) - Add support for bridge connections (gh#agama-project/agama#2258). - Do not crash when network events do not contain "addresses", "nameserver
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 13, 2025
…a SR 1282418 https://build.opensuse.org/request/show/1282418 by user IGonzalezSosa + anag_factory - Propose to move existing connections to disk if there is no one to be persisted (custom config provided) (gh#agama-project/agama#2402). - Copy Agama generated systemd network link files to the target system (bsc#1237327, bsc#1241969). - Version 15 - Set stopOnBootMenu to "true" when a negative timeout is set in the bootloader section of an AutoYaST profile (bsc#1243623). - Add checks to the storage config to avoid using wrong devices as target for boot partitions (gh#agama-project/agama#2390). - Introduce a new ProgressChanged signal which should be used instead of PropertiesChanged (gh#agama-project/agama#2389). - Properly report if registration failed when adding new libzypp service obtained from registration server (bsc#1238851) - Allow to specify a software
imobachgs
added a commit
that referenced
this pull request
Jul 22, 2025
## Problem When we introduced [the ProgressService](#2389) we stop logging the `ProgressChanged` events. ## Solution Log those events too. Move the logic to log the events to a helper function. ## Testing - Tested manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up of #2379.
It is a known problem that the software service can get blocked at several stages and it has an impact in the UI and the CLI. We handled part of that problem in #2364 and #2379, but there are still some cases that are not handled properly.
For instance, during software probing, Agama is not able to return the current progress.
Solution
This PR implements a new
ProgressServicewhich handles and caches the progress for any service.Apart from caching the progress, it offers a centralized way of keeping track of the progress, listening for changes in single place (instead of building and processing an stream of events for each of the services).
The service uses Tokio channels and message passing to share the state.
As part of this change, I have decided to introduce a new
ProgressChangedsignal, which carries the information we need, instead of relying on the genericPropertiesChanged.Testing