Allow to specify a RAID as explicit boot device #2386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces ancorgs#3 (I was not able to re-target it to the proper repository)
Problem
Right now a configuration error is reported if
storage.boot.devicepoints to an entry atmdRaids.A configuration like this:
{ "storage": { "mdRaids": [ { "search": { "max": 1 }, "alias": "raid", "partitions": [ { "search": "*", "delete": true }, { "filesystem": { "path": "/" } } ] } ], "boot": { "configure": true, "device": "raid" } } }...resulted in the error "There is no boot device with alias 'raid'".
Solution
Honor the mentioned setting if the mdRaid entry corresponds to a pre-existing RAID device. Since the configuration is explicit, is the user responsibility to choose a RAID that actually boots.
Testing
Not working
If the entry at
mdRaidscorresponds to a new RAID that will be created during the proposal, then the configuration will be accepted but the proposal will not use the new RAID to allocate the boot partitions. That's kind of expected given the nature of the proposal.Tracked at https://trello.com/c/yuLVe1BR/1585-storage-check-whether-it-makes-sense-to-selecti-a-new-raid-as-boot-device