-
Notifications
You must be signed in to change notification settings - Fork 68
Add bridge support for the HTTP API and CLI #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ce84e0 to
9f6e59d
Compare
bfe1f8b to
b656888
Compare
imobachgs
requested changes
May 16, 2025
Contributor
imobachgs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good (similar to the bonding support), but there is too much cloning.
imobachgs
approved these changes
May 19, 2025
Co-authored-by: Imobach González Sosa <[email protected]>
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 27, 2025
https://build.opensuse.org/request/show/1280489 by user IGonzalezSosa + anag_factory - Version 15 - Proper handling of WebSocket secure connections (gh#agama-project/agama#2391): - "agama monitor" does not use "insecure" by default. - Do not encrypt the connection when using ws: URLs. - Cache progress reporting to avoid blocking the clients (gh#agama-project/agama#2389). - Update schema of the storage model (gh#agama-project/agama#2346). - Provide software conflicts HTTP API (gh#agama-project/agama#2348) - Cache issues to avoid blocking the clients (gh#agama-project/agama#2379). - Cache the software configuration and products in the web server, the software backend is blocked during package installation (bsc#1241208) - Add support for bridge connections (gh#agama-project/agama#2258). - Do not crash when network events do not contain "addresses", "nameserver
imobachgs
added a commit
that referenced
this pull request
Jun 6, 2025
## Problem With #2356 I unfortunately missed the changes from #2258 where `slave-type` was changed to `port-type` which only NM >= 1.46.0 supports. ## Solution Send `port-type` only for NM >= 1.46.0, otherwise `slave-type` is used. Also since I was already adding a test for this, I also added two additional test for `connection_to_dbus` with bridge and bond connections. ## Testing - *Added a new unit test* - *Tested manually*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Although there is a bridge model in the backend, there is no way to configure it through the CLI or through the HTTP api.
Solution
Added bridge support similar to what was added for bonding in (#885) and also fix it because looks like we broke the bonding handling when moved to the HTTP Api (#1064).
An example of the json bridge configuration looks like:
{ "network": { "connections": [ { "id": "Bridge0", "method4": "manual", "interface": "br0", "addresses": ["192.168.1.100/24"], "gateway4": "192.168.1.1", "nameservers": ["192.168.1.1"], "bridge": { "ports": ["eth0", "eth1"], "stp": false } } ] } }Testing