Fix target file path

[teclator]

Problem

The S390x network devices are not activated after the installation because the udev rules are not copying properly to the target system as the relative target path is wrong (/mntetc/udev/rules.d).

• https://bugzilla.suse.com/show_bug.cgi?id=1241868

Solution

Use File.join to ensure the relative target path and the destdir are joined properly.

Testing

• Adapted unit test to fail with the original implementation and fix the code for passing
• Tested manually in agama1

agama1:~ # ls /mnt/etc/udev/rules.d/
41-cio-ignore.rules  41-dasd-eckd-0.0.0160.rules  41-qeth-0.0.0800.rules

[imobachgs]

It looks good as a quick fix (which is already tested). I wonder why we do not need to update the tests, though.

For the future, I guess that working with Pathname objects instead of strings might be a better alternative.

[teclator]

Would be nice to have a unit test for this, but I've checked the whole file test is missing. Since you have tested it manually, go ahead 👍

There is a unit test but unfortunately with the happy path, added end "/" for making it break without the proper fix. Now all of the possible combinations should be equivalent.

irb(main):010> [File.join("/mnt", "/etc/udev/rules.d"), File.join("/mnt/", "/etc/udev/rules.d"), File.join("/mnt/", "etc/udev/rules.d"), File.join("/mnt", "etc/udev/rules.d")].uniq
=> ["/mnt/etc/udev/rules.d"]

[dgdavid]

Would be nice to have a unit test for this, but I've checked the whole file test is missing. Since you have tested it manually, go ahead 👍

There is a unit test

Ah, I see. I was looking in the wrong place 😅