Do not set the root option in /boot/grub2/grub.cfg (bsc#1236873)#2358
Merged
Do not set the root option in /boot/grub2/grub.cfg (bsc#1236873)#2358
Conversation
- It was wrong and the root is already set in the /boot/grub2/earlyboot.cfg file (bsc#1236873) - Replace underscores in the boot menu label by spaces
dgdavid
approved these changes
May 14, 2025
jreidinger
reviewed
May 14, 2025
| - Do not set the root in /boot/grub2/grub.cfg file, it was wrong | ||
| and the root is already set in the /boot/grub2/earlyboot.cfg | ||
| file (bsc#1236873) | ||
| - Replace underscores in the boot menu label by spaces |
Contributor
There was a problem hiding this comment.
would it make sense to replace both? like underscore and also dashes?
Contributor
Author
There was a problem hiding this comment.
Dashes actually cannot be used as the Kiwi profile name is then used as a part of the version in OBS and dash is not allowed in RPM version.
jreidinger
approved these changes
May 14, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/boot/grub2/grub.cfgpoints to a non-existing file, the target name is not constant and is changed/boot/grub2/earlyboot.cfgfile, this line is not needed actuallySolution
Testing
Additional fix