Added inst.copy_network to kernel cmdline and config server no-auto-default #2291
Merged
Added inst.copy_network to kernel cmdline and config server no-auto-default #2291
Conversation
jreidinger
reviewed
Apr 24, 2025
live/live-root/usr/lib/dracut/modules.d/99agama-cmdline/save-agama-conf.sh
Show resolved
Hide resolved
jreidinger
approved these changes
Apr 25, 2025
teclator
added a commit
that referenced
this pull request
Apr 25, 2025
…SLES SAP (#2279) ## Problem It was agreed to install the NetworkManager config server package for both products avoiding the ethernet devices probing and automatic configuration. - https://bugzilla.suse.com/show_bug.cgi?id=1241224 ## Solution Define the NetworkManager-config-server package as mandatory for SLES-16 and SLES_SAP-16. (see also #2291)
teclator
changed the title
teclator
added a commit
that referenced
this pull request
Apr 29, 2025
…sabled explicitly (#2299) ## Problem If there is no network configuration specified through the kernel cmdline then the /run/agama/copy_network is not created and that is wrong as the network configuration written persistently during installation will not be copied to the target system. - related to #2291 ## Solution Modify the check discarding the copy of the network files if disabled explicitly (it will check if the **/run/agama/not_copy_network** file exists). ## Testing - *Tested manually*
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
jlausuch
added a commit
to jlausuch/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 2, 2025
https://jira.suse.com/browse/AGM-147 A new Agama feature make our interfaces in openQA not to get an IP, therefore failing in most cases due to not resolving the network. To be consistent with the previous behavior, we need to add some new parameters in the boot process. Related: - https://trello.com/c/P6oGGmjH/4745-ui-handle-persistent-non-persistent-network-connections - Added NetworkManager config server as mandatory package for SLES and SLES SAP agama-project/agama#2279 - Added inst.copy_network to kernel cmdline and config server no-auto-default agama-project/agama#2291 - https://bugzilla.suse.com/show_bug.cgi?id=1241224
fsimorda
pushed a commit
to fsimorda/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 3, 2025
https://jira.suse.com/browse/AGM-147 A new Agama feature make our interfaces in openQA not to get an IP, therefore failing in most cases due to not resolving the network. To be consistent with the previous behavior, we need to add some new parameters in the boot process. Related: - https://trello.com/c/P6oGGmjH/4745-ui-handle-persistent-non-persistent-network-connections - Added NetworkManager config server as mandatory package for SLES and SLES SAP agama-project/agama#2279 - Added inst.copy_network to kernel cmdline and config server no-auto-default agama-project/agama#2291 - https://bugzilla.suse.com/show_bug.cgi?id=1241224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The network configuration is a crucial part of the installation process. In some cases it is even required to start the installation. The problem is that, in some cases, the network configuration used during the installation could differ to the one wanted in the target system.
It will be nice to be able to configure completely the "picture" of the network after the installation as we started to design in YaST but as a primary step at least would be nice to select if the installation network configuration should be kept or not allowing to disable the copy of the connections completely. Currently that is not possible and the running and persistent configuration are always copied to the target system as well as we probe DHCP over all the ethernet devices even when there is some explicit configuration given.
Solution
We proposed some changes in the current behavior.
First of all, only the persistent configuration will be copied to the target system (default), this copy can be omitted using the
inst.copy_network=0kernel cmdline argument although we are considering to define it as an enum allowingnone, persistent, all and maybe a comma separated name of connectionsbut just keep it simple by now only supporting 0 or 1.During the boot process (dracut), if an explicit NetworkManager configuration is given through the 'ip=' kernel cmdline option then the running configuration will be copied persistently before switching the rootfs and we will also set the no-auto-default=* to not run DHCP over all the ethernet devices when the installer is started.
Testing